From: Sebastian Keller <skeller@gnome.org>
Date: Fri, 29 Apr 2022 21:30:21 +0000 (+0200)
Subject: st/theme-node: Only try to parse non-empty inline styles
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~480^2^2~7
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=f0a04719271e4b9d148362205c2379ef25f7c89b;p=gnome-shell.git

st/theme-node: Only try to parse non-empty inline styles

Otherwise cr_parser_new_from_buf() will fail creating a parser for a
buffer of length 0, resulting in further errors due to the parser being
NULL. This could happen when extensions were trying to set the style of
a widget to an empty string.

Fixes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/4634
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2286>
---

diff --git a/src/st/st-theme-node.c b/src/st/st-theme-node.c
index 13dbca88f..6e09c3939 100644
--- a/src/st/st-theme-node.c
+++ b/src/st/st-theme-node.c
@@ -456,7 +456,7 @@ ensure_properties (StThemeNode *node)
       if (node->theme)
         properties = _st_theme_get_matched_properties (node->theme, node);
 
-      if (node->inline_style)
+      if (node->inline_style && *node->inline_style != '\0')
         {
           CRDeclaration *cur_decl;